gdkwindow: Avoid re-setting the opaque region if it doesn't change

This avoids, at least, needless chatter with the compositor and the X
server in X11's case.

https://bugzilla.gnome.org/show_bug.cgi?id=786469

diff --git a/gdk/gdkinternals.h b/gdk/gdkinternals.h
index 537741bf2a8e2e66839d6ce5ed3b02108e837cae..7e17aeea8a374bc49d972936e14979ac72850ee5 100644 (file)
--- a/gdk/gdkinternals.h
+++ b/gdk/gdkinternals.h
@@ -285,6 +285,8 @@ struct _GdkWindow
   GdkFrameClock *frame_clock; /* NULL to use from parent or default */
 
   GdkDrawingContext *drawing_context;
+
+  cairo_region_t *opaque_region;
 };
 
 #define GDK_WINDOW_TYPE(d) ((((GdkWindow *)(d)))->window_type)

diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c
index 010a27ea7dcb3db3b1ecd68765f31196cd9e935f..09d136c37fe4bd3b29b727510ca6f49292b05413 100644 (file)
--- a/gdk/gdkwindow.c
+++ b/gdk/gdkwindow.c
@@ -404,6 +404,9 @@ gdk_window_finalize (GObject *object)
 
   g_clear_object (&window->display);
 
+  if (window->opaque_region)
+    cairo_region_destroy (window->opaque_region);
+
   G_OBJECT_CLASS (gdk_window_parent_class)->finalize (object);
 }
 
@@ -8142,6 +8145,14 @@ gdk_window_set_opaque_region (GdkWindow      *window,
   g_return_if_fail (GDK_IS_WINDOW (window));
   g_return_if_fail (!GDK_WINDOW_DESTROYED (window));
 
+  if (cairo_region_equal (window->opaque_region, region))
+    return;
+
+  g_clear_pointer (&window->opaque_region, cairo_region_destroy);
+
+  if (region != NULL)
+    window->opaque_region = cairo_region_reference (region);
+
   impl_class = GDK_WINDOW_IMPL_GET_CLASS (window->impl);
 
   if (impl_class->set_opaque_region)